Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Focused tests are still needed for sort_code parsing and string output, covering leading zeros, missing keys, and explicit nulls while confirming absent values leave existing output unchanged.
1 open issue
What changed in this PR
Adds sort_code support to the shared v1 payment-details field used by invoice and financial-document predictions.
Changes:
- Parses and exposes
sort_code, including it in string output when present. - Adds the corresponding nullable string accessor to the RBS signature.
| File | Description |
|---|---|
sig/mindee/v1/parsing/standard/payment_details_field.rbs |
Declares sort_code as String?. |
lib/mindee/v1/parsing/standard/payment_details_field.rb |
Reads, exposes, and formats the sort code. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Types of changes