Skip to content

✨ add sort_code to v1 invoice and findoc - #285

Merged
ianardee merged 1 commit into
mainfrom
sort-code
Nov 18, 2026
Merged

ianardee merged 1 commit into
mainfrom
sort-code

Conversation

@ianardee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Focused tests are still needed for sort_code parsing and string output, covering leading zeros, missing keys, and explicit nulls while confirming absent values leave existing output unchanged.

1 open issue
What changed in this PR

Adds sort_code support to the shared v1 payment-details field used by invoice and financial-document predictions.

Changes:

  • Parses and exposes sort_code, including it in string output when present.
  • Adds the corresponding nullable string accessor to the RBS signature.
File Description
sig/​mindee/​v1/​parsing/​standard/​payment_details_field.rbs Declares sort_code as String?.
lib/​mindee/​v1/​parsing/​standard/​payment_details_field.rb Reads, exposes, and formats the sort code.

Review effort: Balanced

@ianardee
ianardee merged commit acf3c10 into main Nov 18, 2026
56 of 62 checks passed
@ianardee
ianardee deleted the sort-code branch November 18, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants